Skip to content

Conversation

mshabarov
Copy link
Contributor

No description provided.

Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can the junit 5 version be 6? What happens with all existing projects that use 5?

@mshabarov mshabarov moved this from 🔎Iteration reviews to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Oct 8, 2025
@caalador caalador self-assigned this Oct 9, 2025
@caalador caalador moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Oct 9, 2025
@mshabarov mshabarov marked this pull request as draft October 9, 2025 08:02
@mshabarov
Copy link
Contributor Author

How can the junit 5 version be 6? What happens with all existing projects that use 5?

This was just a naive try to check if TestBench sources still compile and can work with JUnit 6.

Locally I had no big problems to build and validate with JUnit 6, so by running mvn clean install -pl vaadin-testbench-integration-tests-junit5,vaadin-testbench-integration-tests I could see that only these things were failing:

  1. ElementScreenCompareIT for JUnit 5 which is unrelated I think.
  2. PerformanceIT also unrelated as this might be my local run specific.

Otherwise the project has built and end-to-end tests passed.

I wonder if we can even avoid a new module specifically for JUnit 6 and just say the JUnit 5 based projects can just set JUnit 6 and continue using TestBench.

@caalador caalador removed their assignment Oct 9, 2025
@caalador caalador moved this from ⚒️ In progress to 🔎Iteration reviews in Vaadin Flow ongoing work (Vaadin 10+) Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎Iteration reviews

Development

Successfully merging this pull request may close these issues.

3 participants