fix: apply index after Java-side filtering in ElementQuery (#2033) #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ElementQuery with conditions like withPropertyValue(), calling first() or get(index) would fail if the element at that DOM position didn't match the condition. This happened because the JavaScript [index] was applied before Java-side condition filtering, so it would extract the wrong element and then filter it out. Fixed by: - Modified get(int index) to check if conditions exist - When conditions exist, fetch all elements and apply index after filtering - When no conditions exist, use the optimized JavaScript [index] path Added integration tests to verify withPropertyValue().first() and withPropertyValue().get(0) work correctly. Fixes #2033
|
Fixes #2033. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.