Skip to content

fix: improve logging for browser startup retry attempts #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: improve logging for browser startup retry attempts #2066

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acdf898
fix: improve logging for browser startup retry attempts
Artur- Nov 11, 2025
c04e533
Merge branch 'main' into simplify-logging
Artur- Nov 11, 2025
a98b892
format
Artur- Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions vaadin-testbench-shared/src/main/java/com/vaadin/testbench/parallel/setup/RemoteDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import com.vaadin.testbench.Parameters;
import com.vaadin.testbench.TestBench;
import com.vaadin.testbench.parallel.SauceLabsIntegration;

public class RemoteDriver {

Expand Down Expand Up @@ -50,10 +51,20 @@ public WebDriver createDriver(String hubURL,
WebDriver driver = new RemoteWebDriver(executor, capabilities);
return TestBench.createDriver(driver);
} catch (Exception e) {
getLogger().error("Browser startup for " + capabilities
+ " failed on attempt " + i, e);
if (i == BROWSER_INIT_ATTEMPTS) {
getLogger().error("Browser startup for " + capabilities
+ " failed on attempt " + i + " (final attempt)",
e);
throw e;
} else {
String testName = getTestName(capabilities);
String testInfo = testName != null ? " for test " + testName
: "";
getLogger().info(
"Browser startup failed on attempt {}/{}{}, retrying...",
i, BROWSER_INIT_ATTEMPTS, testInfo);
getLogger().debug("Browser startup for " + capabilities
+ " failed on attempt " + i, e);
}
}
}
Expand All @@ -64,6 +75,17 @@ public WebDriver createDriver(String hubURL,

private Logger getLogger() {
return LoggerFactory.getLogger(getClass());
}

private String getTestName(DesiredCapabilities capabilities) {
// Try to get test name from sauce:options first (SauceLabs)
Object testName = SauceLabsIntegration.getSauceLabsOption(capabilities,
SauceLabsIntegration.CapabilityType.NAME);
if (testName != null) {
return testName.toString();
}
// Fallback to direct capability
testName = capabilities.getCapability("name");
return testName != null ? testName.toString() : null;
}
}