chore: build production package by default #185
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up Maven build configuration by removing need for production profile. Updates Maven build configuration to run build-frontend goal by default on package phase. With help of spring-boot-maven-plugin feature, includeOptional=false, vaadin-dev dependency is not included in production package. Part of vaadin/flow#22439
Artur-
reviewed
Oct 9, 2025
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| <configuration> | ||
| <!-- Set false to exclude optional dependencies like vaadin-dev. --> | ||
| <includeOptional>false</includeOptional> |
There was a problem hiding this comment.
Isn't this the default in Spring Boot 4?
There was a problem hiding this comment.
Yes, we probably end up removing this for v25 branches. For branches still using SB 3 (if we update those too) it will be true by default.
There was a problem hiding this comment.
I mean the moment when we have something else than SNAPSHOT to use and flow is updated too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up Maven build configuration by removing need for production profile. Updates Maven build configuration to run build-frontend goal by default on package phase. With help of spring-boot-maven-plugin feature, includeOptional=false, vaadin-dev dependency is not included in production package.
Part of vaadin/flow#22439
WIP NOTICE: Requires Spring Boot 4.0.0-SNAPSHOT and running requires Flow compatibility.