feat: allow switching between light/dark Aura theme with theme attribute
#10486
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Nov 13, 2025
jouni
reviewed
Nov 13, 2025
Co-authored-by: Jouni Koivuviita <[email protected]>
web-padawan
force-pushed
the
feat/aura-theme-variant-attributes
branch
from
040d491 to
464a0dc
Compare
|
ugur-vaadin
pushed a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow switching between light / dark Aura theme variants using the
theme="light|dark|light-dark"attribute on thehtmlelement, same as it works for Lumo. This would allow adding a Flow API to toggle between light and dark variants in the same way for both themes (vaadin/flow#22718).Since Aura also supports automatically switching the variant based on the OS default, Aura additionally supports the attribute value
light-dark.Fixes #10484
Type of change