refactor: move RTE background and border to the container #10487
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/rte-move-base-props
branch
3 times, most recently
from
75a020c to
5221801
Compare
jouni
reviewed
Nov 13, 2025
packages/rich-text-editor/src/styles/vaadin-rich-text-editor-base-styles.js
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
refactor/rte-move-base-props
branch
from
5221801 to
d94a454
Compare
web-padawan
force-pushed
the
refactor/rte-move-base-props
branch
from
d94a454 to
c3828b9
Compare
|
jouni
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #10409
As a pre-requisite for adding label / helper / error-message to RTE, let's move base styles to the container.
The difference in max-height screenshot is expected, but I'm not sure about the outline border radius.
Type of change