Skip to content

refactor: implement safe triangle pattern for submenu navigation #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DiegoCardoso wants to merge 13 commits into
base: main
Choose a base branch
from

refactor: extract angle computation to reduce cognitive complexity

fe5e10b
Select commit
Loading
Failed to load commit list.
Draft

refactor: implement safe triangle pattern for submenu navigation #11183

refactor: extract angle computation to reduce cognitive complexity
fe5e10b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 20, 2026 in 53s

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 277 in packages/context-menu/src/vaadin-contextmenu-items-mixin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZyLpspUEuG2vT6-Idt1&open=AZyLpspUEuG2vT6-Idt1&pullRequest=11183

Check warning on line 923 in packages/menu-bar/src/vaadin-menu-bar-mixin.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZyLpsj-EuG2vT6-Idt0&open=AZyLpsj-EuG2vT6-Idt0&pullRequest=11183
View more details on SonarQubeCloud