refactor: expose tooltip open/close via TooltipController#11568
Merged
web-padawan merged 1 commit intomainfrom Apr 27, 2026
Merged
refactor: expose tooltip open/close via TooltipController#11568web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
vursen
force-pushed
the
refactor/tooltip-controller-open-close
branch
2 times, most recently
from
9444ae2 to
e22a0b1
Compare
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
refactor/tooltip-controller-open-close
branch
from
e22a0b1 to
0b1f3ef
Compare
|
vursen
added a commit
that referenced
this pull request
Apr 27, 2026
Adopt the new `TooltipController.open()`/`close()` wrappers from PR #11568 instead of reaching into `tooltip._stateController`, and resolve the tooltip controller once at `ready()` rather than per show/hide. `MenuBarSubmenu` now opts into sharing the parent menu-bar's controller by pre-assigning `_tooltipController` before calling `super.ready()`, which keeps menu-bar specifics out of the generic `ItemsMixin`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
web-padawan
approved these changes
Apr 27, 2026
vursen
added a commit
that referenced
this pull request
Apr 27, 2026
Adopt the new `TooltipController.open()`/`close()` wrappers from PR #11568 instead of reaching into `tooltip._stateController`, and resolve the tooltip controller once at `ready()` rather than per show/hide. `MenuBarSubmenu` now opts into sharing the parent menu-bar's controller by pre-assigning `_tooltipController` before calling `super.ready()`, which keeps menu-bar specifics out of the generic `ItemsMixin`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
added a commit
that referenced
this pull request
Apr 27, 2026
Adopt the new `TooltipController.open()`/`close()` wrappers from PR #11568 instead of reaching into `tooltip._stateController`, and resolve the tooltip controller once at `ready()` rather than per show/hide. `MenuBarSubmenu` now opts into sharing the parent menu-bar's controller by pre-assigning `_tooltipController` before calling `super.ready()`, which keeps menu-bar specifics out of the generic `ItemsMixin`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
added a commit
that referenced
this pull request
Apr 27, 2026
Adopt the new `TooltipController.open()`/`close()` wrappers from PR #11568 instead of reaching into `tooltip._stateController`, and resolve the tooltip controller once at `ready()` rather than per show/hide. `MenuBarSubmenu` now opts into sharing the parent menu-bar's controller by pre-assigning `_tooltipController` before calling `super.ready()`, which keeps menu-bar specifics out of the generic `ItemsMixin`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
added a commit
that referenced
this pull request
Apr 27, 2026
Adopt the new `TooltipController.open()`/`close()` wrappers from PR #11568 instead of reaching into `tooltip._stateController`, and resolve the tooltip controller once at `ready()` rather than per show/hide. `MenuBarSubmenu` now opts into sharing the parent menu-bar's controller by pre-assigning `_tooltipController` before calling `super.ready()`, which keeps menu-bar specifics out of the generic `ItemsMixin`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
open(options)andclose(immediate)toTooltipControllerthat delegate to the slotted tooltip's state controller, so callers no longer need to reach into the private_stateController. Migratesmenu-barandgridover, and drops the unusedsetOpenedmethod (plus its tests). Also moves themenu-bartooltip controller setup from the public class into the mixin, alongside the other controllers.Prerequisite for #11549.
Type of change
🤖 Generated with Claude Code