Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with example URL query string in README.md and added documentation for validating request path parameters #121

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

snnair
Copy link
Contributor

@snnair snnair commented Mar 12, 2024

Line 214 exemplifies the use of validating query string URL parameters using the library. However, the example was using the wrong query string parameter - "uuid", whereas the preceding JSON schema (tokenSchema) starting from line 188, was checking for a property called "token".

snnair added 2 commits March 12, 2024 16:16
Line 214 exemplifies the use of validating query string URL parameters using the library. However, the example was using the wrong query string parameter - "uuid", whereas the preceding JSON schema (tokenSchema) starting from line 188, was checking for a property called "token".
Currently, there is no documentation/example on how one could go about validating request path parameters, even though the library supports this. Added an example for the same.
@snnair snnair changed the title fix: issue with example URL query string in README.md fix: issue with example URL query string in README.md and added documentation for validating request path parameters Mar 12, 2024
@snnair
Copy link
Contributor Author

snnair commented Mar 13, 2024

Hi @simonplend, please let me know if this is fine, or if I need to add any specific descriptors to the documentation text.

Copy link
Collaborator

@simonplend simonplend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for the PR @snnair!

@simonplend simonplend merged commit 1398af0 into vacekj:main Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants