chore(vscode): update Solidity formatter and package defaults #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3esmit
force-pushed
the
update-vscode-config
branch
from
830969d to
2ca24b1
Compare
3esmit
force-pushed
the
update-vscode-config
branch
from
2ca24b1 to
6b5f036
Compare
Collaborator
|
According to Paul's response, the nomicfoundation one is the better option... Not even sure vscode settings should be part of this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply config suggested by foundry in https://book.getfoundry.sh/config/vscode
We actually should discuss if the change of solidity formatter is a good suggestion from the docs.
JuanBlanco.solidity is the most popular, but NomicFoundation.hardhat-solidity seem to integrate better. Just for example, JuanBlanco.solidity does not follow the solc defined in foundry.toml, which made me create this pre-commit hook script just to keep it in sync with the project config.
Related to PaulRBerg#60
See also juanfranblanco/vscode-solidity#463
We might recosnider the
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?