Fix sequence number overflow handling #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add epoch tracking to handle uint32 wraparound safely Implement overflow detection and epoch increme
Author
|
@Ben-PH @richard-ramos Could you please take a look? |
Member
|
cc: @AkshayaMani |
vladopajic
reviewed
Aug 29, 2025
Comment on lines
+49
to
+61
| if a.epoch != b.epoch: | ||
| if a.epoch < b.epoch: | ||
| return -1 | ||
| else: | ||
| return 1 | ||
|
|
||
| # Same epoch, compare counters normally | ||
| if a.counter < b.counter: | ||
| return -1 | ||
| elif a.counter > b.counter: | ||
| return 1 | ||
| else: | ||
| return 0 |
Member
There was a problem hiding this comment.
Suggested change
| if a.epoch != b.epoch: | |
| if a.epoch < b.epoch: | |
| return -1 | |
| else: | |
| return 1 | |
| # Same epoch, compare counters normally | |
| if a.counter < b.counter: | |
| return -1 | |
| elif a.counter > b.counter: | |
| return 1 | |
| else: | |
| return 0 | |
| if a.epoch == b.epoch: | |
| return a.counter - b.counter | |
| return a.epoch - b.epoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add epoch tracking to handle uint32 wraparound safely Implement overflow detection and epoch increment
Links: Issues