Skip to content

feat: interop #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: interop #1303

wants to merge 1 commit into from

Conversation

richard-ramos
Copy link
Member

No description provided.

@richard-ramos
Copy link
Member Author

image

@vladopajic, @kaiserd ! :) good news:
Only zig failed interop with an ERR_CRYPTO 🤔 meaning that there might be an issue with the certificate (either what they send or how we validate it?)

@richard-ramos
Copy link
Member Author

Looking good now:

image

I was missing ED25519 from the list of supported algos for certificates

@richard-ramos
Copy link
Member Author

Now the only thing left is to make adding security managers / muxers optional, depending on the transports you add

Base automatically changed from interop to master March 31, 2025 13:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (504d161) to head (b8354e0).

Files with missing lines Patch % Lines
libp2p/builders.nim 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
- Coverage   84.74%   84.73%   -0.01%     
==========================================
  Files          97       97              
  Lines       17522    17525       +3     
==========================================
+ Hits        14849    14850       +1     
- Misses       2673     2675       +2     
Files with missing lines Coverage Δ
libp2p/builders.nim 94.40% <66.66%> (-0.53%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaiserd kaiserd moved this from new to In Progress in nim-libp2p Apr 4, 2025
@richard-ramos richard-ramos marked this pull request as ready for review April 10, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants