test(gossipsub): Topic Membership Tests - updated

[rlve]

This PR tries to revive another stale PR with tests - test(gossipsub): Topic Membership Tests - which I just closed.

Actions taken:

• copied the tests from the original PR
• updated them to the latest conventions
• removed unnecessary tests:
  • "subscription limit test" - test had a wrong assumption around the limit of the topic a local node can subscribe to and test logic itself was incorrect, another test around this already exist:

    nim-libp2p/tests/pubsub/testgossipsubmessagehandling.nim

    Line 113 in 4d0b4ec

    asyncTest "subscription limits":

  • "handle JOIN topic and mesh is updated" - doesn't add anything new, repeats "mesh and gossipsub populated when subscribed"
  • "multiple peers join and leave topic simultaneously" - doesn't add anything new, repeats "handle SUBSCRIBE and UNSUBSCRIBE multiple topics"

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (ccb24b5) to head (2d8aa2a).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
  Coverage   84.64%   84.65%           
=======================================
  Files          97       97           
  Lines       17522    17525    +3     
=======================================
+ Hits        14832    14836    +4     
+ Misses       2690     2689    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmelodie]

LGTM besides the nitpicks