Skip to content

Conversation

@richard-ramos
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 11, 2025 20:13
@richard-ramos richard-ramos requested a review from a team as a code owner December 11, 2025 20:13
@richard-ramos richard-ramos requested review from gmelodie and vladopajic and removed request for a team December 11, 2025 20:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the QuicSession.close() method by changing from sequential to concurrent stream closing. The change improves shutdown performance by allowing all streams in a session to close in parallel rather than waiting for each one to complete before starting the next.

Key changes:

  • Replaced sequential for loop with concurrent allFutures for closing multiple streams
  • Maintained proper error isolation using noCancel wrapper

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-project-automation github-project-automation bot moved this from new to In Progress in nim-libp2p Dec 11, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.94%. Comparing base (f33f064) to head (00a851c).
⚠️ Report is 2 commits behind head on lsquic.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           lsquic    #1966      +/-   ##
==========================================
+ Coverage   71.89%   71.94%   +0.04%     
==========================================
  Files         140      140              
  Lines       17854    17824      -30     
  Branches       19       19              
==========================================
- Hits        12836    12823      -13     
+ Misses       5018     5001      -17     
Files with missing lines Coverage Δ
libp2p/transports/quictransport.nim 91.71% <100.00%> (-0.06%) ⬇️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants