feat(android): simulator#2827
Merged
Merged
Conversation
richard-ramos
force-pushed
the
android-simulator
branch
from
July 14, 2026 16:53
7ab5800 to
ffc3d28
Compare
richard-ramos
marked this pull request as ready for review
July 14, 2026 16:55
richard-ramos
requested review from
gmelodie and
vladopajic
and removed request for
a team
July 14, 2026 16:55
vladopajic
approved these changes
Jul 14, 2026
gmelodie
approved these changes
Jul 14, 2026
richard-ramos
force-pushed
the
master
branch
2 times, most recently
from
July 14, 2026 21:51
0da0bce to
ae39cbb
Compare
richard-ramos
force-pushed
the
android-simulator
branch
from
July 15, 2026 01:26
ffc3d28 to
b506e59
Compare
richard-ramos
enabled auto-merge
July 15, 2026 01:33
Contributor
|
hm, this looks interesting - could you backport something like this to nim-chronos so that its test suite run on android as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds runtime coverage to the Android mobile CI by running the x86_64
libp2p_ffi_android_checkbinary inside an Android emulator.The workflow now:
liblibp2p.so,libc++_shared.so, and the check binary to the deviceLD_LIBRARY_PATHset and fails CI unless it exits withRC=0Affected Areas
Android GitHub Actions workflow for the mobile FFI build.
Impact on Library Users
No API or runtime behavior changes for library users. This only expands CI validation for Android artifacts.
Risk Assessment
Low risk. The new emulator step is limited to the x86_64 Android CI matrix entry; arm64 continues to build and verify artifacts without emulator execution.