fix(service-disco): wait time cap

[SionoiS]

A much better version of #2825

Thanks @jm-clius

[codecov-commenter]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.23%. Comparing base (bb37d02) to head (5bc2bf7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
libp2p/protocols/service_discovery/registrar.nim	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files         170      170           
  Lines       30750    30750           
  Branches       13       12    -1     
=======================================
+ Hits        24979    24981    +2     
+ Misses       5771     5769    -2     

Files with missing lines	Coverage Δ
libp2p/protocols/service_discovery/registrar.nim	67.25% <66.66%> (+0.66%)	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR improves Service Discovery registrar behavior by capping computed wait times to advertExpiry (so the registrar never asks an advertiser to wait longer than the advert’s own lifetime) and by making registration() use second-level time granularity consistently.

Changes:

• Clamp waitingTime()’s returned Duration to <= discoConfig.advertExpiry.
• Replace the max/min pair with a single clamp() call for bounding the floating-point wait value.
• Quantize registration()’s now timestamp to whole seconds and add tests covering both the wait cap and the timestamp granularity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
libp2p/protocols/service_discovery/registrar.nim	Adds an advertExpiry cap to waitingTime() and truncates registration()’s now to whole-second granularity.
tests/libp2p/service_discovery/test_registrar.nim	Adds coverage for the advertExpiry cap behavior and verifies second-granularity timestamps emitted by registration().