Skip to content

chore: README#76

Merged
richard-ramos merged 2 commits into
mainfrom
readme
Mar 26, 2026
Merged

chore: README#76
richard-ramos merged 2 commits into
mainfrom
readme

Conversation

@richard-ramos

Copy link
Copy Markdown
Member

No description provided.

@richard-ramos
richard-ramos requested a review from a team as a code owner March 24, 2026 19:59
@richard-ramos
richard-ramos requested review from Copilot, gmelodie and vladopajic and removed request for a team March 24, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces the placeholder README with a full project overview for nim-lsquic, including background, features, installation instructions, a Quick Start example, development notes, and module documentation.

Changes:

  • Added a complete README describing the library’s purpose, API surface, and relationship to vendored lsquic/BoringSSL submodules.
  • Added install/requirements and development workflow documentation (tests, formatting, FFI regeneration).
  • Added a Quick Start example and a module index table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +140 to +142
- [`tests/test_lifecycle.nim`](tests/test_lifecycle.nim)
- [`tests/test_verifier.nim`](tests/test_verifier.nim)
- [`tests/test_stress.nim`](tests/test_stress.nim)

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README links to test files that don't exist in this repository (tests/test_lifecycle.nim, tests/test_verifier.nim, tests/test_stress.nim). Please update this list to point at the actual test entry points (e.g., tests/test_connection.nim, tests/test_perf.nim, and/or tests/test_all.nim) or add the missing files if they are intended to exist.

Suggested change
- [`tests/test_lifecycle.nim`](tests/test_lifecycle.nim)
- [`tests/test_verifier.nim`](tests/test_verifier.nim)
- [`tests/test_stress.nim`](tests/test_stress.nim)
- [`tests/test_perf.nim`](tests/test_perf.nim)
- [`tests/test_all.nim`](tests/test_all.nim)

Copilot uses AI. Check for mistakes.
Comment thread README.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 26, 2026 19:22
@richard-ramos
richard-ramos merged commit 8a29aee into main Mar 26, 2026
17 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +180 to +188
| Module | Description |
| --- | --- |
| [`lsquic`](lsquic.nim) | Top-level import that re-exports the main public API |
| [`lsquic/lsquic`](lsquic/lsquic.nim) | Process-wide `lsquic` initialization and cleanup |
| [`lsquic/client`](lsquic/client.nim) | `QuicClient` creation, dialing, and transport shutdown |
| [`lsquic/server`](lsquic/server.nim) | `QuicServer`, `Listener`, binding, and `accept()` |
| [`lsquic/connection`](lsquic/connection.nim) | Connection lifecycle, stream creation, certificate access |
| [`lsquic/stream`](lsquic/stream.nim) | Async stream reads, writes, close, and abort |
| [`lsquic/tlsconfig`](lsquic/tlsconfig.nim) | TLS configuration plus PEM-to-X509/PKey helpers |

Copilot AI Mar 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Modules table is written with double leading pipes (|| ...) which creates an extra empty column and renders incorrectly on GitHub. Use standard Markdown table syntax with a single leading | per row (and matching header separator row) so the table displays as intended.

Suggested change
| Module | Description |
| --- | --- |
| [`lsquic`](lsquic.nim) | Top-level import that re-exports the main public API |
| [`lsquic/lsquic`](lsquic/lsquic.nim) | Process-wide `lsquic` initialization and cleanup |
| [`lsquic/client`](lsquic/client.nim) | `QuicClient` creation, dialing, and transport shutdown |
| [`lsquic/server`](lsquic/server.nim) | `QuicServer`, `Listener`, binding, and `accept()` |
| [`lsquic/connection`](lsquic/connection.nim) | Connection lifecycle, stream creation, certificate access |
| [`lsquic/stream`](lsquic/stream.nim) | Async stream reads, writes, close, and abort |
| [`lsquic/tlsconfig`](lsquic/tlsconfig.nim) | TLS configuration plus PEM-to-X509/PKey helpers |
| Module | Description |
| --------------------------------------- | --------------------------------------------------------------- |
| [`lsquic`](lsquic.nim) | Top-level import that re-exports the main public API |
| [`lsquic/lsquic`](lsquic/lsquic.nim) | Process-wide `lsquic` initialization and cleanup |
| [`lsquic/client`](lsquic/client.nim) | `QuicClient` creation, dialing, and transport shutdown |
| [`lsquic/server`](lsquic/server.nim) | `QuicServer`, `Listener`, binding, and `accept()` |
| [`lsquic/connection`](lsquic/connection.nim) | Connection lifecycle, stream creation, certificate access |
| [`lsquic/stream`](lsquic/stream.nim) | Async stream reads, writes, close, and abort |
| [`lsquic/tlsconfig`](lsquic/tlsconfig.nim) | TLS configuration plus PEM-to-X509/PKey helpers |

Copilot uses AI. Check for mistakes.
@richard-ramos
richard-ramos deleted the readme branch April 23, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants