fix: call engine_process synchronously if possible, otherwise defer to ticker event loop#78
Merged
Conversation
…o ticker event loop
richard-ramos
requested review from
gmelodie and
vladopajic
and removed request for
a team
April 6, 2026 23:32
There was a problem hiding this comment.
Pull request overview
This PR changes how QUIC engine processing is triggered so that engine_process runs immediately when invoked from user code, while preventing re-entrant processing by deferring nested calls back onto the timeout-driven event loop.
Changes:
- Add a
processingre-entrancy guard toQuicContext.engine_process. - Change
processWhenReadyto callengine_processsynchronously instead of only scheduling the timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gmelodie
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.