fix: guard engine callbacks after QuicContext shutdown#82
Merged
Conversation
richard-ramos
requested review from
Copilot,
gmelodie and
vladopajic
and removed request for
a team
April 17, 2026 20:53
There was a problem hiding this comment.
Pull request overview
This PR hardens the QUIC context lifecycle by adding defensive guards to prevent lsquic engine callbacks from running after a QuicContext has been shut down, reducing the chance of use-after-free / nil dereference crashes during teardown.
Changes:
- Add early-return guards in packet receive and engine processing paths when
ctxorctx.engineis nil. - Add shutdown guards to connection operations (
processWhenReady,close,abort,makeStream) to avoid invoking lsquic on a destroyed engine. - Bump package version to
0.1.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lsquic/context/io.nim |
Prevents packet ingestion after context/engine shutdown. |
lsquic/context/context.nim |
Adds shutdown guards around engine processing and connection/stream operations. |
lsquic.nimble |
Version bump for the bugfix release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gmelodie
approved these changes
Apr 17, 2026
vladopajic
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.