Skip to content

chore(ffi): generate lsquic bindings with nodeclguards#90

Merged
richard-ramos merged 2 commits into
mainfrom
nodeclguards
Jun 17, 2026
Merged

chore(ffi): generate lsquic bindings with nodeclguards#90
richard-ramos merged 2 commits into
mainfrom
nodeclguards

Conversation

@richard-ramos

@richard-ramos richard-ramos commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

Regenerates the lsquic FFI bindings with -d:nodeclguards for increased readability. Also updates CI targets so they match nim-libp2p (Using nim2.0 would trigger errors with these changes)

The manual enum and CID definitions are moved into lsquic/lsquic_ffi_types.nim so both the generator and final prelude compile against the same definitions. The generator filters symbols supplied by that shared file and rewrites aliases that should resolve to already-known Nim types, including manual enums, BoringSSL structs, and SockAddr.

Affected Areas

  • Build / Tooling
    • Updates the Futhark generation flags and removes generated-file SockAddr post-processing from build.sh.
  • Other
    • Adds shared FFI type definitions included by both prelude.nim and generate_lsquic_ffi.nim.
    • Regenerates lsquic/lsquic_ffi.nim without Futhark declaration guards.

References

Copilot AI review requested due to automatic review settings June 17, 2026 15:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@richard-ramos richard-ramos changed the title chore: nodeclguards chore(ffi): generate lsquic bindings with nodeclguards Jun 17, 2026
@richard-ramos
richard-ramos marked this pull request as ready for review June 17, 2026 16:14
@richard-ramos
richard-ramos requested a review from a team as a code owner June 17, 2026 16:14
@richard-ramos
richard-ramos requested review from Copilot, gmelodie and vladopajic and removed request for a team June 17, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@richard-ramos
richard-ramos merged commit b57ea88 into main Jun 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants