chore(ffi): generate lsquic bindings with nodeclguards#90
Merged
Conversation
richard-ramos
marked this pull request as ready for review
June 17, 2026 16:14
richard-ramos
requested review from
Copilot,
gmelodie and
vladopajic
and removed request for
a team
June 17, 2026 16:14
vladopajic
approved these changes
Jun 17, 2026
gmelodie
approved these changes
Jun 17, 2026
richard-ramos
force-pushed
the
nodeclguards
branch
from
June 17, 2026 17:54
5bb59e0 to
08e0c3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the lsquic FFI bindings with
-d:nodeclguardsfor increased readability. Also updates CI targets so they match nim-libp2p (Using nim2.0 would trigger errors with these changes)The manual enum and CID definitions are moved into
lsquic/lsquic_ffi_types.nimso both the generator and final prelude compile against the same definitions. The generator filters symbols supplied by that shared file and rewrites aliases that should resolve to already-known Nim types, including manual enums, BoringSSL structs, andSockAddr.Affected Areas
SockAddrpost-processing frombuild.sh.prelude.nimandgenerate_lsquic_ffi.nim.lsquic/lsquic_ffi.nimwithout Futhark declaration guards.References