fix: android msg_iovlen type#98
Merged
Merged
Conversation
richard-ramos
requested review from
gmelodie and
vladopajic
and removed request for
a team
July 10, 2026 20:10
There was a problem hiding this comment.
Pull request overview
This PR adjusts platform-specific sendmsg struct initialization to avoid using an incompatible msg_iovlen type on Android, and bumps the package version accordingly.
Changes:
- Exclude Android from the Linux x86_64
msg_iovlen(csize_t) branch so Android uses thecintassignment path. - Bump
lsquicnimble package version from0.5.4to0.6.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lsquic/context/io.nim | Adjusts compile-time platform branching so Android uses the correct msg_iovlen cast for Tmsghdr. |
| lsquic.nimble | Updates the published package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gmelodie
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exclude Android from the Linux x86_64
msg_iovlenbranch insendPacketsOut.Android x86_64 should use the
cintfield type, while the existing Linux x86_64 path keeps usingcsize_t.This also bumps the package version to
0.5.5.Affected Areas
Transports
QUIC packet output now selects the Android-compatible
Tmsghdr.msg_iovlentype on Android x86_64.Build / Tooling
Updates
lsquic.nimblefrom0.5.4to0.5.5.Impact on Library Users
No API changes.
Downstream projects that cross-compile for Android x86_64 can consume this release instead of carrying a local patch for the
msg_iovlentype mismatch.Risk Assessment
Low. The condition only changes behavior when
androidis defined; existing Linux x86_64 builds keep the previouscsize_tpath.