Skip to content

fix: android msg_iovlen type#98

Merged
richard-ramos merged 3 commits into
mainfrom
fix/android-msg-iovlen-type
Jul 11, 2026
Merged

fix: android msg_iovlen type#98
richard-ramos merged 3 commits into
mainfrom
fix/android-msg-iovlen-type

Conversation

@richard-ramos

@richard-ramos richard-ramos commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

Exclude Android from the Linux x86_64 msg_iovlen branch in sendPacketsOut.

Android x86_64 should use the cint field type, while the existing Linux x86_64 path keeps using csize_t.

This also bumps the package version to 0.5.5.

Affected Areas

  • Transports
    QUIC packet output now selects the Android-compatible Tmsghdr.msg_iovlen type on Android x86_64.

  • Build / Tooling
    Updates lsquic.nimble from 0.5.4 to 0.5.5.

Impact on Library Users

No API changes.

Downstream projects that cross-compile for Android x86_64 can consume this release instead of carrying a local patch for the msg_iovlen type mismatch.

Risk Assessment

Low. The condition only changes behavior when android is defined; existing Linux x86_64 builds keep the previous csize_t path.

Copilot AI review requested due to automatic review settings July 10, 2026 20:10
@richard-ramos
richard-ramos requested a review from a team as a code owner July 10, 2026 20:10
@richard-ramos
richard-ramos requested review from gmelodie and vladopajic and removed request for a team July 10, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts platform-specific sendmsg struct initialization to avoid using an incompatible msg_iovlen type on Android, and bumps the package version accordingly.

Changes:

  • Exclude Android from the Linux x86_64 msg_iovlen (csize_t) branch so Android uses the cint assignment path.
  • Bump lsquic nimble package version from 0.5.4 to 0.6.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lsquic/context/io.nim Adjusts compile-time platform branching so Android uses the correct msg_iovlen cast for Tmsghdr.
lsquic.nimble Updates the published package version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 10, 2026 20:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread lsquic.nimble
@richard-ramos
richard-ramos merged commit 0797689 into main Jul 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants