You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was requested to use newer version of Rust, so I added the https://github.com/oxalica/rust-overlay to have the most recent rust toolchain. Some of the dependencies needed to compile everything (make all) within shell weren't there so I had to add them. Also, within the Makefile the installation of wasm-pack using script downloaded from the internet was replaced with installation using cargo - same result but more safe.
Hey! I’ve made some changes related to the rln-wasm module in this PR, which now requires installing wasm-bindgen-cli and binaryen. That PR is currently under review for merging into master.
This PR may need updates to stay in sync, so it's best to wait until the other PR is merged before reviewing.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was requested to use newer version of Rust, so I added the https://github.com/oxalica/rust-overlay to have the most recent rust toolchain. Some of the dependencies needed to compile everything (
make all
) within shell weren't there so I had to add them. Also, within the Makefile the installation ofwasm-pack
using script downloaded from the internet was replaced with installation using cargo - same result but more safe.