Bug fix/destruct http instance#17
Open
wildbeastsenpai wants to merge 4 commits intovadimpronin:masterfrom
Open
Bug fix/destruct http instance#17wildbeastsenpai wants to merge 4 commits intovadimpronin:masterfrom
wildbeastsenpai wants to merge 4 commits intovadimpronin:masterfrom
Conversation
added 4 commits
March 8, 2018 22:19
vadimpronin
force-pushed
the
master
branch
2 times, most recently
from
e295b96 to
576f57b
Compare
vadimpronin
force-pushed
the
master
branch
2 times, most recently
from
06a1595 to
00761a4
Compare
vadimpronin
force-pushed
the
master
branch
9 times, most recently
from
f049dbc to
a1c1112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear sir,
I found that it seems to be failing to release a port when using 'http' package with guacamole-lite as like as written in README.md. I fixed the lib/Server.js, as to be destructing http explicitly. I would be grateful if you would merge this commit.
Thanks for creating a great npm package.