Fix Lorem generator API inconsistencies and type mismatches#157
Open
muhammadahmad665 wants to merge 1 commit into
Open
Conversation
- Updated words(amount:) to return [String] instead of String - Implemented proper random character generation for characters(amount:) - Fixed sentence capitalization logic - Refactored loops using map for cleaner Swift style - Aligned implementation with documented Fakery Lorem API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few inconsistencies in the
Loremgenerator so it matches what’s actually documented in Fakery.A couple of things were slightly off — mainly return types and a few internal implementations that didn’t really line up with the expected API.
What changed
Breaking change
Small one to be aware of:
If you were relying on the old behavior, just join it manually:
faker.lorem.words(amount: 3).joined(separator: " ")