Completed RewardValue Class and Unit Tests for Cash-to-Miles and Miles-to-Cash Conversions #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request finalizes the implementation of the RewardValue class and completes the associated unit tests. The following changes were made:
Implemented RewardValue Class:
Added two constructors for handling both cash and miles input. The class handles the conversion between cash and miles using a predefined conversion rate.
cashValue is converted to milesValue using a conversion rate of 1 mile = $0.0035 and vice versa.
Added Unit Tests:
Test 1: Cash to Miles Conversion: Verifies that cash is properly converted to miles using the conversion rate (cash ÷ 0.0035 = miles).
Test 2: Miles to Cash Conversion: Ensures miles are accurately converted to cash using the reverse conversion (miles × 0.0035 = cash).
Both tests now pass, confirming that the conversion logic works as expected. The class now provides accurate conversions between cash and miles, covering key edge cases.