This repository was archived by the owner on Jun 25, 2023. It is now read-only.
Rename VMware Fusion support to VMware Desktop #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 2016-03-26, HashiCorp released the VMware Desktop Plugin, which replaced the existing VMware Fusion implementation. With the rename, the hooks that Landrush needs to start services can no longer be called. Renaming those makes those work again. Fixes vagrant-landrush#334.
Collaborator
|
I can't test this. |
Author
|
I would've liked to have tested my changes too, but I couldn't work out how to do it. Running it locally, I found I wasn't able to run the tests for Landrush whilst having the (private) VMware provider plugin installed. I don't suppose you have any suggestions? |
Collaborator
|
I never used VMware + Vagrant, so no. |
This attempts to document the need for the new plugin model, which should be enough to prompt anyone upgrading to know that they need it. https://www.hashicorp.com/blog/introducing-the-vagrant-vmware-desktop-plugin/
davividal
approved these changes
May 22, 2020
Collaborator
|
@hferentschik this one looks fine for me. |
Author
|
I'm conscious that this has been sat a little while without any activity. Is there anything I can help with to move this along? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2016-03-26, HashiCorp released the VMware Desktop Plugin, which
replaced the existing VMware Fusion implementation. With the rename, the
hooks that Landrush needs to start services can no longer be called.
Renaming those makes those work again.
Fixes #334.