Fix segmentation fault caused by infinite recursion and unsafe array …#213
Merged
vaibhavpandeyvpz merged 2 commits intoJan 4, 2026
Merged
Conversation
…access - Fix infinite recursion in ProcessUtils::runCommand(): skip javaExe() call when searching for java via which/where commands to prevent recursive loop - Fix unsafe array access in VersionResolveWorker::resolve(): add isEmpty() check before accessing result.output[0] when checking Java version The segfault occurred because runCommand() called javaExe() to set JAVA_HOME, which called findInPath() that called runCommand(which, java) again, creating an infinite recursion loop.
Owner
|
This should fix #212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…access
The segfault occurred because runCommand() called javaExe() to set JAVA_HOME, which called findInPath() that called runCommand(which, java) again, creating an infinite recursion loop.