Fix local config system #223
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #220:
We already have support for local config already! But nobody uses it and it is broken. If you try to update a value that is already set in global config in your local config, it errors, saying that it is already set. I just removed all of this logic, since it seems like it just makes things more complicated for no reason. If you try to set something that's already set it should just overwrite it to the new value, even if it is the same value as before.
Two issues:
.deepPartial()and I can't really find any suggested alternatives. https://www.npmjs.com/package/zod-deep-partial seems to do the trick. I kinda don't love this dep, maybe we can vendor just the object handling piece, or maybe it doesn't matter.