Skip to content

Conversation

@404Wolf
Copy link
Collaborator

@404Wolf 404Wolf commented Dec 29, 2025

In light of #220:

We already have support for local config already! But nobody uses it and it is broken. If you try to update a value that is already set in global config in your local config, it errors, saying that it is already set. I just removed all of this logic, since it seems like it just makes things more complicated for no reason. If you try to set something that's already set it should just overwrite it to the new value, even if it is the same value as before.

Two issues:

@tmcw
Copy link
Member

tmcw commented Jan 8, 2026

Nice - yeah, I think that vendoring that third-party dep makes a lot of sense. Looked around and it doesn't seem like switching validators would be an easy fix - arktype and effect schema don't seem to have deepPartial either.

I'm a bit concerned about is people mistakenly commiting their local configs with their apiKey to git.

Recommending .gitignore feels like the most we can do without being too magic or overbearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants