Repository navigation
respect client snippet support - #346
Merged
Merged
Conversation
Prince781
force-pushed
the
agent/respect-snippet-support
branch
2 times, most recently
from
August 9, 2026 13:49
9c6e378 to
406747a
Compare
Prince781
marked this pull request as ready for review
August 9, 2026 13:58
Prince781
force-pushed
the
agent/respect-snippet-support
branch
from
August 9, 2026 14:30
406747a to
608de3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VLS currently generates snippet completions even when the client doesn't advertise support. Only create snippets when the client supports them, fallback to ordinary text, or omit the suggestion.
Add LSP integration tests for both cases.
Closes #342