Skip to content

SpaceBeforeParenCheck: fix column offset #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinkiama merged 4 commits into from
Sep 3, 2026
Merged

SpaceBeforeParenCheck: fix column offset #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab633a0
SpaceBeforeParenCheck: fix column offset
x1z53 Feb 21, 2026
4998a25
Merge branch 'master' into master
colinkiama May 12, 2026
b5f94e7
Merge branch 'master' into master
colinkiama Sep 3, 2026
1e6f6e9
Fix SpaceBeforeParens check offsets in tests
colinkiama Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Checks/SpaceBeforeParenCheck.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class ValaLint.Checks.SpaceBeforeParenCheck : Check {
foreach (ParseResult r in parse_result) {
if (r.type == ParseType.DEFAULT) {
add_regex_mistake ("""[^_\s{\[\(\)!~]\(""", _("Expected space before paren"), r,
ref mistake_list, 1, 1);
ref mistake_list, 1, 0);
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions test/ContentTest.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class ContentTest : GLib.Object {
var general_warnings = CheckTest.FileTestMistakeList ();
general_warnings.add ("using-directive", 3);
general_warnings.add ("naming-convention", 3);
general_warnings.add ("space-before-paren", 2, 26, 27);
general_warnings.add ("space-before-paren", 2, 25, 26);
general_warnings.add ("note", 1, 21, 25, "TODO");
general_warnings.add ("note", 1, 21, 38, "TODO: Lorem ipsum");
general_warnings.add ("double-spaces", 2, 25, 27);
Expand Down Expand Up @@ -105,9 +105,9 @@ class ContentTest : GLib.Object {
check_contents_for_mistake (CheckTest.get_test_file ("note-check.vala"), note_warnings);

var space_before_paren_warnings = CheckTest.FileTestMistakeList ();
space_before_paren_warnings.add ("space-before-paren", 4, 9, 10);
space_before_paren_warnings.add ("no-space", 5, 14, 15);
space_before_paren_warnings.add ("space-before-paren", 0, 14, 15);
space_before_paren_warnings.add ("space-before-paren", 4, 8, 9);
space_before_paren_warnings.add ("space-before-paren", 5, 13, 14);
space_before_paren_warnings.add ("no-space", 0, 14, 15);
space_before_paren_warnings.add ("no-space", 0, 17, 18);
space_before_paren_warnings.add ("no-space", 0, 18, 19);
check_contents_for_mistake (CheckTest.get_test_file ("space-before-paren-check.vala"),
Expand Down
8 changes: 4 additions & 4 deletions test/FileTest.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class FileTest : GLib.Object {
var general_warnings = CheckTest.FileTestMistakeList ();
general_warnings.add ("using-directive", 3);
general_warnings.add ("naming-convention", 3);
general_warnings.add ("space-before-paren", 2, 26, 27);
general_warnings.add ("space-before-paren", 2, 25, 26);
general_warnings.add ("note", 1, 21, 25, "TODO");
general_warnings.add ("note", 1, 21, 38, "TODO: Lorem ipsum");
general_warnings.add ("double-spaces", 2, 25, 27);
Expand Down Expand Up @@ -100,9 +100,9 @@ class FileTest : GLib.Object {
check_file_for_mistake (CheckTest.get_test_file ("note-check.vala"), note_warnings);

var space_before_paren_warnings = CheckTest.FileTestMistakeList ();
space_before_paren_warnings.add ("space-before-paren", 4, 9, 10);
space_before_paren_warnings.add ("no-space", 5, 14, 15);
space_before_paren_warnings.add ("space-before-paren", 0, 14, 15);
space_before_paren_warnings.add ("space-before-paren", 4, 8, 9);
space_before_paren_warnings.add ("space-before-paren", 5, 13, 14);
space_before_paren_warnings.add ("no-space", 0, 14, 15);
space_before_paren_warnings.add ("no-space", 0, 17, 18);
space_before_paren_warnings.add ("no-space", 0, 18, 19);
check_file_for_mistake (CheckTest.get_test_file ("space-before-paren-check.vala"),
Expand Down
Loading