[player] Fix player hanging when terminate #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very particular path to reproduce the issue : - Server must stop sending RTSP stream - Player::stop() and Player::setSources() call after Reasons: When source is set, demuxer is "terminated" (method used to reset it). But this method will hang in this particular case, for 10/15 seconds, due to `av_read_frame` (called by auto packet = demuxer.read()` inside `QAVPlayer::doDemux` method) It seems that FFMPEG doesn't provide a non-blocking equivalent method (flag AVIO_FLAG_NONBLOCK exist but support is really experimental : https://ffmpeg-devel.ffmpeg.narkive.com/k3jOJEmZ/av-read-frame-question-about-blocking). According to multiple thread on this issue : - https://stackoverflow.com/questions/14558172/ffmpeg-av-read-frame-need-very-long-time-to-stop - https://stackoverflow.com/questions/65408224/using-asio-to-implement-interrupt-callback-for-ffmpeg Using a custom `AVFormatContext::interrupt_callback` is the way to do, good thing is that `QAvDemuxer` already provide it and also already provide an option to perform the `abort`. So, be sure to enable `abort` property before explicitly ask to wait for the demuxer to finish (note that setting sources isn't the only way to trigger it, simply destroying player, which call terminate, will trigger this behaviour)
valbok
reviewed
Dec 4, 2024
|
|
||
| demuxer.abort(); | ||
| demuxerFuture.waitForFinished(); | ||
| demuxer.abort(false); |
Owner
There was a problem hiding this comment.
interesting why second call is needed there?
Contributor
Author
There was a problem hiding this comment.
I have added it to "reset" to his previous state (since abort is false by default). Thus, other methods from FFmpeg will not be prematurely aborted (thinking about TEARDOWN signals not being sent for example).
Owner
There was a problem hiding this comment.
oh, forgot that can reset the flag. As I see it is reset already in onLoad, so should work without this line.
legerch
added a commit
to legerch/qtavplayer
that referenced
this pull request
Dec 5, 2024
Work initially started here : 3bf856a Then 2 PRs in the mainline project has been done related to this subject: - valbok/QtAVPlayer#498 - valbok/QtAVPlayer#500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix player from hanging when demuxer terminate method is called.
More details on this issue will be find inside : #497