Added several Mission atlantic developments and a shelve fixer tool#121
Open
Added several Mission atlantic developments and a shelve fixer tool#121
Conversation
valeriupredoi
requested changes
Dec 12, 2023
Owner
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
lots of small bits, bud 🍺
| time_key = year+month | ||
| else: | ||
| time_key = year | ||
|
|
Owner
There was a problem hiding this comment.
what if month is str but not length 1?
| default=[None, ], | ||
| nargs='+', | ||
| type=str, | ||
| help='One or more months - default is all months', |
Owner
|
can you also add to the executables list and add a basic run test for it in the github action, pls? |
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of Mission Atlantic fixes and an entirely new tool.
So this affects a lot of files (51!), but most of them are Mission Atlantic yml files, so nothing too major.
A new tool,
revert_shelve(possibly not the best name - happy to change it), now takes a few command line arguments and allows the deletion of specific years and months of processed data in the bgcval2 shelve datasets. This was needed because we found a fault in the MA runs and needed to go back and re-simulate a few years.In terms of actual changes:
maxno longer overwritesmeanplots.SENEMOand can keep the standard/YEAR/MN/directory structure. (This is why all MA files have been changed.)analysis_comparetool.