Draft
Conversation
valeriupredoi
approved these changes
Mar 4, 2026
Owner
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
as long as you reckon it's good to go @ledm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #144
NEMO 4.2 changes the grid, and some hard-wired grid locations need to be edited for it to be suitable. I've hacked a solution here, but I'll see if I can think of a better approach before getting there.
The important changes related to #114 are in bgcval2/functions/circulation.py, but this PR also includes several other changes to the code.