Improve help messages and interface for single job#40
Conversation
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
looks good - I'll have to write a test for the new helper funcs, in a separate PR 🍺
| import argparse | ||
|
|
||
| import sys | ||
| from sys import stdout |
There was a problem hiding this comment.
you can use sys.stdout since you are now importing sys
| fnDict[yr] = 1 | ||
|
|
||
| if not numberfiles: | ||
| numberfiles = np.max([v for v in fnDict.values()]) |
There was a problem hiding this comment.
fnDict.values() is already a list, no need to iterate over
|
|
||
| if not numberfiles: | ||
| numberfiles = np.max([v for v in fnDict.values()]) | ||
| if debug:print('numberfiles:', numberfiles) |
| for y in years: | ||
| if int(y) % dividby != 0: continue | ||
| if int(y) % dividby == 0: | ||
| if debug: print('Found year:', y) |
|
did you just make it a draft? I swear it was a RfR PR when I opened it - never mind, it's good to go as is if you wanna merge (see the few comments) |
I actually just read the description 🤦♂️ 🤣 |
|
Lol, thanks! This review will be useful, but I'm leaving this on the backburner until #39 is a bit better. |
|
This also will make several changes to |
cool! I got us a branch to fix tests as soon as this gets in - actually that's gonna be a bit more of a general fix tests branch, where I'll add moar testing too |
2 participants
This tool builds on the issues described in #37.
Still very much a draft, and is a lower priority than developments elsewhere, as the single job work is not used as much right now.