isEmojy added. #1890

erfiboy · 2021-12-23T07:45:15Z

codecov · 2021-12-23T07:46:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f055c11) to head (ea013c5).
Report is 216 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1890   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik

Don't forget to add tests

WikiRik · 2022-01-02T15:59:23Z

README.md

@@ -111,6 +111,7 @@ Validator                               | Description
 **isEAN(str)**                          | check if the string is an EAN (European Article Number).
 **isEmail(str [, options])**            | check if the string is an email.<br/><br/>`options` is an object which defaults to `{ allow_display_name: false, require_display_name: false, allow_utf8_local_part: true, require_tld: true, allow_ip_domain: false, domain_specific_validation: false, blacklisted_chars: '', host_blacklist: [] }`. If `allow_display_name` is set to true, the validator will also match `Display Name <email-address>`. If `require_display_name` is set to true, the validator will reject strings without the format `Display Name <email-address>`. If `allow_utf8_local_part` is set to false, the validator will not allow any non-English UTF8 character in email address' local part. If `require_tld` is set to false, e-mail addresses without having TLD in their domain will also be matched. If `ignore_max_length` is set to true, the validator will not check for the standard max length of an email. If `allow_ip_domain` is set to true, the validator will allow IP addresses in the host part. If `domain_specific_validation` is true, some additional validation will be enabled, e.g. disallowing certain syntactically valid email addresses that are rejected by GMail. If `blacklisted_chars` receives a string, then the validator will reject emails that include any of the characters in the string, in the name part. If `host_blacklist` is set to an array of strings and the part of the email after the `@` symbol matches one of the strings defined in it, the validation fails. 
 **isEmpty(str [, options])**            | check if the string has a length of zero.<br/><br/>`options` is an object which defaults to `{ ignore_whitespace:false }`.
+**isEmojy(str)**              | check if the string contains any emojis.


Suggested change

**isEmojy(str)** | check if the string contains any emojis.

**isEmoji(str)** | check if the string contains any emojis.

WikiRik · 2022-01-02T15:59:33Z

src/lib/isEmojy.js

@@ -0,0 +1,7 @@
+import assertString from './util/assertString';
+
+export default function isEmojy(str) {


Suggested change

export default function isEmojy(str) {

export default function isEmoji(str) {

rubiin

Add tests please. That would ensure fast approval

rubiin

Also the file name and validator name, plese rename to isEmoji

profnandaa · 2022-04-22T03:00:48Z

Thanks for this, please make the changes suggested and we should land this in.

HyungJu · 2022-05-17T08:28:10Z

src/lib/isEmojy.js

+
+export default function isEmojy(str) {
+  assertString(str);
+  const regexExp = /(\u00a9|\u00ae|[\u2000-\u3300]|\ud83c[\ud000-\udfff]|\ud83d[\ud000-\udfff]|\ud83e[\ud000-\udfff])/gi;


It's broken expression.

It matches Korean character. #1968

pano9000 · 2022-12-01T21:33:54Z

one tiny additional issue I see here:

What is the intended goal here?

a) check if a string contains any emojis
OR
b) check if the string IS an emoji

Both of which could be valid use cases, I guess, but in any case expectation and result should match:

Currently the validator is called "isEmoji" - and to me this suggests that it tests case b)
Howecer it actually tests case a) instead:

E.g. isEmojy("abc😂def") will return true

EDIT+
Ok, somehow I missed, that #1968 exists
That PR is adressing the issue above, and went for checking for case b) :-)

erfiboy added 3 commits December 23, 2021 11:01

Detecting emojy.

4678cd4

IsEmogy description added to readme.

e8be1d9

d

ea013c5

erfiboy mentioned this pull request Dec 23, 2021

Can we have a isEmoji validator ? #1889

Open

WikiRik requested changes Jan 2, 2022

View reviewed changes

rubiin requested changes Mar 25, 2022

View reviewed changes

profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Apr 22, 2022

WikiRik mentioned this pull request May 17, 2022

feat(emoji): add emoji validator #1968

Open

3 tasks

HyungJu suggested changes May 17, 2022

View reviewed changes

rubiin added the duplicate Duplicate issue label Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

isEmojy added. #1890

isEmojy added. #1890

erfiboy commented Dec 23, 2021 •

edited

Loading

codecov bot commented Dec 23, 2021 •

edited

Loading

WikiRik left a comment

WikiRik Jan 2, 2022

WikiRik Jan 2, 2022

rubiin left a comment

rubiin left a comment

profnandaa commented Apr 22, 2022

HyungJu May 17, 2022

pano9000 commented Dec 1, 2022 •

edited

Loading

	isEmojy(str) \| check if the string contains any emojis.
	isEmoji(str) \| check if the string contains any emojis.

		@@ -0,0 +1,7 @@
		import assertString from './util/assertString';

		export default function isEmojy(str) {

	export default function isEmojy(str) {
	export default function isEmoji(str) {

isEmojy added. #1890

Are you sure you want to change the base?

isEmojy added. #1890

Conversation

erfiboy commented Dec 23, 2021 • edited Loading

codecov bot commented Dec 23, 2021 • edited Loading

Codecov Report

WikiRik left a comment

Choose a reason for hiding this comment

WikiRik Jan 2, 2022

Choose a reason for hiding this comment

WikiRik Jan 2, 2022

Choose a reason for hiding this comment

rubiin left a comment

Choose a reason for hiding this comment

rubiin left a comment

Choose a reason for hiding this comment

profnandaa commented Apr 22, 2022

HyungJu May 17, 2022

Choose a reason for hiding this comment

pano9000 commented Dec 1, 2022 • edited Loading

erfiboy commented Dec 23, 2021 •

edited

Loading

codecov bot commented Dec 23, 2021 •

edited

Loading

pano9000 commented Dec 1, 2022 •

edited

Loading