fix(isMobilePhone): fix macedonian mobile phone numbers validation #2497#2516
Open
shaktisaluja wants to merge 2 commits intovalidatorjs:masterfrom
Open
fix(isMobilePhone): fix macedonian mobile phone numbers validation #2497#2516shaktisaluja wants to merge 2 commits intovalidatorjs:masterfrom
shaktisaluja wants to merge 2 commits intovalidatorjs:masterfrom
Conversation
skpanagiotis
suggested changes
Jan 19, 2025
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
|
Also after a little searching, there is already a PR for North Macedonian mobile phone number. Check this #2500. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
isMobilePhonefunction to validate Macedonian mobile phone numbers correctly.Changes:
+389,070,071, etc.), ensuring that the validation works correctly for both local and international formats.References:
+389and are followed by a 9-digit local number.+389 XXX XXX XXX070 XXX XXX,071 XXX XXX, etc.