fix: update ES import path in documentation#2685
Open
zamadye wants to merge 1 commit intovalidatorjs:masterfrom
Open
fix: update ES import path in documentation#2685zamadye wants to merge 1 commit intovalidatorjs:masterfrom
zamadye wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2685 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2595 2595
Branches 659 659
=========================================
Hits 2595 2595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
tried adding tests but having issues. could you give more details? |
Member
|
From the issue it seems that extensions are the reason why the es might not work for some people but we haven't looked into it fully. It would be nice to have a proper test harness for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, i noticed the tree-shakeable import example was using
validator/es/lib/isEmailbut the es folder doesn't exist in the package. changed it tovalidator/lib/isEmailwhich actually works.fixes #2528
let me know if you need any changes!