Skip to content

fix: update ES import path in documentation#2685

Open
zamadye wants to merge 1 commit intovalidatorjs:masterfrom
zamadye:master
Open

fix: update ES import path in documentation#2685
zamadye wants to merge 1 commit intovalidatorjs:masterfrom
zamadye:master

Conversation

@zamadye
Copy link

@zamadye zamadye commented Mar 13, 2026

hey, i noticed the tree-shakeable import example was using validator/es/lib/isEmail but the es folder doesn't exist in the package. changed it to validator/lib/isEmail which actually works.

fixes #2528

let me know if you need any changes!

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9fa1e3a) to head (a881783).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2685   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2595      2595           
  Branches       659       659           
=========================================
  Hits          2595      2595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zamadye
Copy link
Author

zamadye commented Mar 14, 2026

tried adding tests but having issues. could you give more details?

@WikiRik
Copy link
Member

WikiRik commented Mar 14, 2026

#2528 (comment)

From the issue it seems that extensions are the reason why the es might not work for some people but we haven't looked into it fully. It would be nice to have a proper test harness for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Issue: Incorrect ES Import Path

2 participants