Do not render i18n value of enum if data is nil #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the lib tries to render the i18n value of the field even
when it is nil. The problem with this is that when you have some
i18n of it like the following:
matrimonial_regimes:
community_property: Comunhão universal de bens
partial_property: Comunhão parcial de bens
separate_property: Separação de bens
the lib renders all values on the page as a hash:
{:community_property=>"Comunhão universal de bens",
:partial_property=>"Comunhão parcial de bens",
:separate_property=>"Separação de bens"}
This happens because the i18n key used on the view
"activerecord.attributes.#{field.resource.class.name.underscore}.
will render everything on the top level of my enum translations.
This commit changes the views to not try to render if data is nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lib tries to render the i18n value of the field even when it is nil. The problem with this is that when you have some i18n of it like the following:
matrimonial_regimes:
community_property: Comunhão universal de bens
partial_property: Comunhão parcial de bens
separate_property: Separação de bens
the lib renders all values on the page as a hash:
{:community_property=>"Comunhão universal de bens", :partial_property=>"Comunhão parcial de bens",
:separate_property=>"Separação de bens"}
This happens because the i18n key used on the view "activerecord.attributes.#{field.resource.class.name.underscore}.
will render everything on the top level of my enum translations.
This commit changes the views to not try to render if data is nil.