Fix pack_command type annotation to accept variable-length tuples#55
Merged
Fix pack_command type annotation to accept variable-length tuples#55
Conversation
Co-authored-by: mkmkme <4062234+mkmkme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pack_command type annotation to accept multiple elements
Fix pack_command type annotation to accept variable-length tuples
Nov 12, 2025
mkmkme
approved these changes
Nov 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the type annotation for the pack_command function to properly reflect that it accepts variable-length tuples rather than single-element tuples.
- Fixed
pack_commandtype signature fromTuple[T]toTuple[T, ...]to accept variable-length tuples - Added missing
-> bytesreturn type annotation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bogdanp05
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pack_commandtype annotation incorrectly specifiedTuple[str | int | float | bytes | memoryview], which accepts only single-element tuples. The function actually accepts variable-length tuples as evidenced by its test suite.Changes:
Tuple[T]toTuple[T, ...]to accept variable-length tuples-> bytesreturn type annotationExample:
Related to redis/hiredis-py#195
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.