Add CI job that builds with RDMA support enabled#184
Merged
bjosv merged 3 commits intovalkey-io:mainfrom Mar 26, 2025
Merged
Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Let `make install` depend on the install-rdma target when rdma is enabled. Includes some additional cleanups. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
When building with CMake using ENABLE_RDMA=ON and BUILD_SHARED_LIBS=OFF the build fails. libvalkey_rdma.a uses `vk_usec_now` from libvalkey.a and the build is corrected by changing the link order. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
@pizhenwei I was not able to set you as a reviewer, but please check so I haven't destroyed anything you need. |
Contributor
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job will make sure that
ENABLE_RDMA/USE_RDMAflags builds.Includes 2 corrections:
make install.Updated
make installto depend on theinstall-rdmatarget when RDMA is enabled.Includes some additional cleanups.
client_test.When building with CMake using ENABLE_RDMA=ON and BUILD_SHARED_LIBS=OFF the build fails.
libvalkey_rdma.ausesvk_usec_nowfromlibvalkey.a, and this is fixed by correcting the link order.