Fix linker errors when building with cmake, TLS and -Wl,--no-undefined#248
Merged
bjosv merged 6 commits intovalkey-io:mainfrom Oct 16, 2025
andreasstieger:cmake
Merged
Fix linker errors when building with cmake, TLS and -Wl,--no-undefined#248bjosv merged 6 commits intovalkey-io:mainfrom andreasstieger:cmake
bjosv merged 6 commits intovalkey-io:mainfrom
andreasstieger:cmake
Conversation
Part of #247 Signed-off-by: Andreas Stieger <Andreas.Stieger@gmx.de>
Collaborator
|
This seems to cause an ASAN issue ( I'll have to verify locally to confirm. |
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Add TLS and/or RDMA source code when a feature is enabled. Use correct dependencies, but avoid adding a dependency to the target valkey::valkey which results in ODR warnings. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
|
@michael-grunder is this PR good enough? |
Collaborator
|
My cmake is limited, but looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #247