Merged
Conversation
The file command.c needs to include fmacros.h to enable 'strncasecmp' on Solaris (using _XOPEN_SOURCE), but since command.c also uses 'alloca' we need to make sure that api is available on FreeBSD. Since 'alloca' is not visible when using _POSIX_C_SOURCE or _XOPEN_SOURCE on FreeBSD (they unsets __BSD_VISIBLE) we disable them on FreeBSD. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI job and some fixes to build on Solaris.
The file
command.cneeds to includefmacros.hto enablestrncasecmpon Solaris (using_XOPEN_SOURCE),but since
command.calso usesallocawe need to make sure it's available on FreeBSD.Since
allocais not visible when using_POSIX_C_SOURCEor_XOPEN_SOURCEon FreeBSD (they unsets__BSD_VISIBLE) we have to remove these defines on FreeBSD.