Support slotmap updates using CLUSTER NODES in RESP3#262
Merged
bjosv merged 1 commit intovalkey-io:mainfrom Nov 25, 2025
Merged
Support slotmap updates using CLUSTER NODES in RESP3#262bjosv merged 1 commit intovalkey-io:mainfrom
bjosv merged 1 commit intovalkey-io:mainfrom
Conversation
When the option VALKEY_OPT_USE_CLUSTER_NODES is enabled the slot map is updated using the 'CLUSTER NODES' command. If a user has enabled RESP3 by sending the 'HELLO 3' command the 'CLUSTER NODES' response is a verbatim string instead of a bulk string. Update so we handle this reply type as well. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Nov 25, 2025
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Great.
The parser already strips the txt: prefix so user commands are not affected?
Collaborator
Author
|
Yes, the 4 bytes are skipped in createStringObject before given to the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the option
VALKEY_OPT_USE_CLUSTER_NODESis enabled the slot map is updated using theCLUSTER NODEScommand. If a user has enabled RESP3 by sending theHELLO 3command theCLUSTER NODESresponse is a verbatim string instead of a bulk string.Update so we handle this reply type as well.