Fix compilation warnings from Solaris Developer Studio#267
Merged
michael-grunder merged 1 commit intovalkey-io:mainfrom Dec 8, 2025
Merged
Conversation
This lets us build on solaris without disabling -Werror * Switches from `UL` to `ULL` for very large constants in sds.c * Removes `break` statements when they immediately follow an unconditional goto. Signed-off-by: michael-grunder <michael.grunder@gmail.com>
michael-grunder
force-pushed
the
allow-werror-on-solaris
branch
from
01d2839 to
ea2fb9f
Compare
Collaborator
Author
|
I've got one more after this that adds I acquired an oracle cert and key which we can add to secrets to get it running here. It wasn't too bad: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us build on solaris without disabling -Werror
ULtoULLfor very large constants in sds.cbreakstatements when they immediately follow an unconditional goto.