Replace use of alloca() and add latest commands from Valkey 9 and official modules#272
Replace use of alloca() and add latest commands from Valkey 9 and official modules#272bjosv merged 6 commits intovalkey-io:mainfrom
alloca() and add latest commands from Valkey 9 and official modules#272Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Use a fixed size of 64 bytes for commands and 64 bytes for sub-commands. Return a parse failure when the input is larger than that. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Import command json files from: - valkey-json 1.0.2 - valkey-bloom 1.0.0 - valkey-search 1.0.2 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
|
@michael-grunder The CI build says the Oracle cert is invalid now. |
|
@bjosv I think Oracle automatically locked the account, which would be very on brand for Oracle. I can try to create another account and try to figure out how to prevent them from doing that in the future. Just disabling that CI workflow for now seems reasonable though so this doesn't block anything. Edit: The key and cert seem fine? I was able to install in a local VM. I'll play around with it in CI to see if I can figure it out. |
|
I am officially confused 😄 I pushed a branch to try and debug this, but those succeed: I didn't change the certs or keys, only added some verification commands. Maybe it's because I uploaded the secrets? That seems unlikely but I don't know very much about how GH secrets work. |
…lkey` repo Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
|
I added an if-statement for the CI job now so its only run when we push a PR to main, or if the PR was created directly from a branch in the libvalkey repo, i.e. it wont be run on forks or on PRs from forks. |
Replace problematic
alloca()with fixed stack allocation.Use the generous fixed size of 64 bytes for commands, and 64 bytes for sub-commands.
Return a parse failure when out of bounds.
Update
cmddef.hwith latest commands from Valkey 9.0.0,and add commands from official modules:
Fixes #263