Fix binary safety of cluster key lookup functions#296
Open
bjosv wants to merge 2 commits intovalkey-io:mainfrom
Open
Fix binary safety of cluster key lookup functions#296bjosv wants to merge 2 commits intovalkey-io:mainfrom
bjosv wants to merge 2 commits intovalkey-io:mainfrom
Conversation
valkeyClusterGetSlotByKey and valkeyClusterGetNodeByKey used strlen() to determine the key length, which truncated keys containing embedded null bytes, resulting in incorrect slot calculations and node lookups. Add an explicit keylen parameter so callers provide the actual key length, consistent with how the rest of the library handles binary-safe keys. This is a breaking API change. Reference: https://valkey.io/topics/keyspace/ Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
valkeyClusterGetSlotByKeyandvalkeyClusterGetNodeByKeyusedstrlen()to determine the key length,which truncated keys containing embedded null bytes, resulting in incorrect slot calculations and node lookups.
Add an explicit keylen parameter so callers provide the actual key length, consistent with how the rest of the library handles binary-safe keys.
This is a breaking API change.
References: