Skip to content
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ jobs:

- name: Test baseline
run: |
# Install Spring Data Valkey (used by starter)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not the test target come before the install?

Also, why not to split the invocations into the separate steps - i will make life easire in the github UI

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we make the project multi-module this can be simplified, for now we need to manually install Spring Data Valkey before we can use the starter as it relies on Spring Data Valkey and the two modules are not connected through a parent module yet.

./mvnw -s settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
install -DskipTests \
-Dgpg.skip=true \
-B

# Test Spring Data Valkey
./mvnw -s settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
Expand All @@ -103,6 +112,14 @@ jobs:
-Dvalkey.server.version=${{ matrix.version }} \
-U -B

# Test Spring Boot starter
cd spring-boot-starter-data-valkey
../mvnw -s ../settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
test \
-U -B

ci-runtimehints-tests:
needs: generate-test-matrices
runs-on: ubuntu-latest
Expand Down
23 changes: 21 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,37 @@ jobs:

- name: Test and build release artifacts
run: |
# Install Spring Data Valkey (used by starter)
./mvnw -s settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
clean package javadoc:jar test \
install -DskipTests \
-Dgpg.skip=true \
-B

# Test Spring Data Valkey
./mvnw -s settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
package javadoc:jar test \
-Pnone \
-DrunLongTests=true \
-Dvalkey.server.version=8.1.1 \
-U -B

# Test Spring Boot starter
cd spring-boot-starter-data-valkey
../mvnw -s ../settings.xml \
-Ddevelocity.storage.directory=$HOME/.develocity-root \
-Dmaven.repo.local=$HOME/.m2/spring-data-valkey \
package javadoc:jar test \
-U -B

- name: Create draft release
uses: softprops/action-gh-release@v2
with:
draft: true
files: target/*.jar
files: |
target/*.jar
spring-boot-starter-data-valkey/target/*.jar
generate_release_notes: true
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ build
.vscode/
out
work
appendonlydir
*.rdb
*.aof
build/
Expand Down
Loading