Benchmark: Allow for SDV commit-id input, add network emulation inputs#64
Merged
Benchmark: Allow for SDV commit-id input, add network emulation inputs#64
Conversation
Signed-off-by: Lior Sventitzky <liorsve@amazon.com>
Signed-off-by: Lior Sventitzky <liorsve@amazon.com>
ikolomi
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR -
Updates the SDV build flow to match Glide’s. It uses the
resp-bench's default version of SDV by default (the SDV version already configured inresp-bench/pom.xml), while still allowing an override through workflow inputs when a specific commit-id or version is provided. If a commit-id is supplied, SDV is cloned at that exact commit and built from source. Cloning is used instead of checking out within the existing repo so that commits older than the benchmarking infrastructure can be tested. This fully decouples the benchmark orchestration from the SDV build process.Adds support for network emulation by introducing three new workflow inputs: