Benchmark: Handle valkey-glide primary driver commit ID#66
Conversation
045ba5d to
58e4c1f
Compare
.github/workflows/benchmark.yml
Outdated
| echo "version=$SDV_VERSION" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Install valkey-glide build dependencies | ||
| - name: Install valkey-glide build dependencies (primary) |
There was a problem hiding this comment.
These two install dependencies + build glide steps in the primary case are identical to the two existing steps of installing + building in the secondary case. You can just modify the condition for the already existing steps to include the primary case, and make sure the Update resp-bench driver versions step handles replacing the versions in the right places.
There was a problem hiding this comment.
I merged the dependencies steps, but cannot do the same for the build steps as the step ids (build-glide-primary and build-glide-secondary) must be different as they are used by other steps in the workflow.
.github/workflows/benchmark.yml
Outdated
| # Otherwise, update the version supplied in the pom.xml. | ||
| PRIMARY_VERSION="${{ steps.inputs.outputs.primary_version }}" | ||
| PRIMARY_IS_COMMIT="${{ steps.driver-info.outputs.primary_is_commit }}" | ||
| if [ "$DRIVER_ID" != "spring-data-valkey" ] && [ -n "$PRIMARY_VERSION" ]; then |
There was a problem hiding this comment.
Maybe it would be a bit cleaner to integrate it with the previous block that updates the SDV version? something like
if [ -n "$PRIMARY_VERSION" ]; then
case "$DRIVER_ID" in
spring-data-valkey)
if [ "$PRIMARY_IS_COMMIT" = "true" ]; then
...
else
...
fi
;;
valkey-glide)
if [ "$PRIMARY_IS_COMMIT" = "true" ]; then
...
else
...
fi
;;
jedis|lettuce|redisson)
...
;;
esac
fi
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
58e4c1f to
6dc159d
Compare
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Extends primary driver commit ID support to valkey-glide. Jedis, Lettuce, and other drivers only support a maven version.
Tested by running benchmarks against a published version and a commit hash in the valkey-glide repo.