Change cluster client aggregation to test minimum clients#72
Open
jeremyprime wants to merge 1 commit intovalkey-io:mainfrom
Open
Change cluster client aggregation to test minimum clients#72jeremyprime wants to merge 1 commit intovalkey-io:mainfrom
jeremyprime wants to merge 1 commit intovalkey-io:mainfrom
Conversation
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Collaborator
how come? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test frequently fails due to a race condition between measuring the cluster-wide client count and summing individual node counts as connections can be created/destroyed between the two measurements. Instead of verifying an exact count, verify the cluster-wide count is at least the minimum expected from individual nodes.
Ran CI tests a few times in a row without a single failure.